search

tornaia / karma-sonarqube-unit-reporter

A Karma plugin. Unit tests execution report for SonarQube/Generic Coverage Plugin
MIT License
33 stars 28 forks source link

Adding support for unit tests with 'suite', 'describe.only', etc. #25

Closed amalgupta08 closed 6 years ago

amalgupta08 commented 6 years ago

Added a function which will search for keywords like describe, describe.only, describe, suite, suite.only, etc in the file. Earlier only describe was checked, therefore if the file contains describe.only or say there is a space after describe like, describe ('test', ()=>{}) the test were throwing error. After this commit these situations will be handled.

tornaia commented 6 years ago

Thanks for your contribution! 0.0.16 was just released!

tornaia commented 6 years ago

I see some problems with this, will come back to you soon.

amalgupta08 commented 6 years ago

Thanks for reviewing the PR. Please let me know the problems.

tornaia commented 6 years ago

I found 2 problems after I merged the PR this plugin

  1. The plugin did not work anymore as expected (the test result xml file was not created) that is why I reverted. (Project I used is also available on github - in case u want to check on your own what went wrong: https://github.com/tornaia/hr2/tree/master/hr2-angular-ui )
  2. The eslint complained because of many small problems.

Sorry for coming back to you just so late.