torodb / stampede

The ToroDB solution to provide better analytics on top of MongoDB and make it easier to migrate from MongoDB to SQL
https://www.torodb.com/stampede/
GNU Affero General Public License v3.0
1.76k stars 118 forks source link

unify _id constants #154

Closed adescoms closed 7 years ago

adescoms commented 7 years ago

Unify Constants and utilities for “_id” in DefaultIdUtils and refactor the code

codecov-io commented 7 years ago

Codecov Report

Merging #154 into devel will decrease coverage by -0.01%. The diff coverage is 8.33%.

@@             Coverage Diff              @@
##              devel     #154      +/-   ##
============================================
- Coverage     18.23%   18.23%   -0.01%     
+ Complexity     1506     1505       -1     
============================================
  Files           736      735       -1     
  Lines         26438    26436       -2     
  Branches       2322     2322              
============================================
- Hits           4822     4820       -2     
+ Misses        21314    21313       -1     
- Partials        302      303       +1
Impacted Files Coverage Δ Complexity Δ
...b/repl/commands/impl/CreateCollectionReplImpl.java 15.78% <ø> (ø) 2 <ø> (ø) :x:
.../java/com/torodb/torod/impl/memory/MemoryData.java 25.71% <ø> (ø) 2 <ø> (ø) :x:
...mands/signatures/repl/ReplSetGetStatusCommand.java 0% <ø> (ø) 0 <ø> (ø) :x:
.../java/com/torodb/mongodb/utils/DefaultIdUtils.java 0% <ø> (ø) 0 <ø> (ø) :x:
...godb/repl/commands/impl/CreateIndexesReplImpl.java 41.55% <ø> (ø) 6 <ø> (ø) :x:
...ngodb/language/update/SetDocumentUpdateAction.java 0% <ø> (ø) 0 <ø> (ø) :x:
...db/commands/impl/general/InsertImplementation.java 0% <ø> (ø) 0 <ø> (ø) :x:
...db/commands/impl/general/UpdateImplementation.java 0% <ø> (ø) 0 <ø> (ø) :x:
...orodb/mongodb/commands/pojos/ReplicaSetConfig.java 0% <ø> (ø) 0 <ø> (ø) :x:
...om/torodb/mongodb/commands/pojos/MemberConfig.java 0% <ø> (ø) 0 <ø> (ø) :x:
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c589f33...ce3ca18. Read the comment docs.