torognes / swarm

A robust and fast clustering method for amplicon-based studies
GNU Affero General Public License v3.0
123 stars 23 forks source link

not all memory is freed when swarm exits with an error #103

Closed frederic-mahe closed 7 years ago

frederic-mahe commented 7 years ago

This is a very minor issue.

valgrind indicates that some blocks are still reachable when swarm exits after an error (no abundance value in this toy example):

printf ">s1\nA\n" | valgrind swarm

# for a full report
printf ">s1\nA\n" | valgrind --leak-check=full --show-leak-kinds=all swarm
torognes commented 7 years ago

When fatal errors occur the program often terminates without explicitly freeing memory. All memory will be freed automatically afterwards when the program exits. I do not think this should be considered an error.

frederic-mahe commented 7 years ago

Agreed.