Compilation warnings with the new GCC 8.0

[frederic-mahe]

gcc (GCC) 8.0.1 20180128 (experimental)
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

nw.cc: In function 'void pushop(char, char**, char*, int*)':
nw.cc:38:14: warning: 'char* strncpy(char*, const char*, size_t)' output may be truncated copying between 1 and 11 bytes from a string of length 24 [-Wstringop-truncation]
       strncpy(*cigarendp, buf, len);
       ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
nw.cc: In function 'void finishop(char**, char*, int*)':
nw.cc:55:14: warning: 'char* strncpy(char*, const char*, size_t)' output may be truncated copying between 1 and 11 bytes from a string of length 24 [-Wstringop-truncation]
       strncpy(*cigarendp, buf, len);
       ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
nw.cc: In function 'void nw(char*, char*, char*, char*, long int*, long unsigned int, long unsigned int, long unsigned int*, long unsigned int*, long unsigned int*, char**, unsigned char*, long unsigned int*, long unsigned int, long unsigned int)':
nw.cc:38:14: warning: 'char* strncpy(char*, const char*, size_t)' output may be truncated copying between 1 and 10 bytes from a string of length 24 [-Wstringop-truncation]
       strncpy(*cigarendp, buf, len);
       ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
nw.cc:38:14: warning: 'char* strncpy(char*, const char*, size_t)' output may be truncated copying between 1 and 10 bytes from a string of length 24 [-Wstringop-truncation]
       strncpy(*cigarendp, buf, len);
       ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
nw.cc:38:14: warning: 'char* strncpy(char*, const char*, size_t)' output may be truncated copying between 1 and 10 bytes from a string of length 24 [-Wstringop-truncation]
       strncpy(*cigarendp, buf, len);
       ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
nw.cc:38:14: warning: 'char* strncpy(char*, const char*, size_t)' output may be truncated copying between 1 and 10 bytes from a string of length 24 [-Wstringop-truncation]
       strncpy(*cigarendp, buf, len);
       ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
nw.cc:38:14: warning: 'char* strncpy(char*, const char*, size_t)' output may be truncated copying between 1 and 10 bytes from a string of length 24 [-Wstringop-truncation]
       strncpy(*cigarendp, buf, len);
       ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
nw.cc:55:14: warning: 'char* strncpy(char*, const char*, size_t)' output may be truncated copying between 1 and 10 bytes from a string of length 24 [-Wstringop-truncation]
       strncpy(*cigarendp, buf, len);
       ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~

See GCC 8.0 changes for some details.

[torognes]

Probably fixed in a recent commit (08564891dc0b6fd64da09ee269d01748ad3fc847) but it is difficult for me to test it as none of our machines have gcc 8.

[frederic-mahe]

No more warnings and all tests pass :smile: swarm will soon be officially compatible with gcc 8.