search

torognes / swarm

A robust and fast clustering method for amplicon-based studies
GNU Affero General Public License v3.0
121 stars 23 forks source link

avoid variable shadowing, same naming scheme as other local variables #136

Closed frederic-mahe closed 4 years ago

frederic-mahe commented 4 years ago

cppcheck says:

[swarm/src/algo.cc:182] -> [swarm/src/algo.cc:321]: (style) Local variable listlen shadows outer variable

Since other local variables are named subseed[something], it seems logical to use the same naming scheme. But I am not really sure I understand the code completely, so please feel free to reject the pull request.

torognes commented 4 years ago

Looks fine. I'll do likewise for the other variables.