torognes / swarm

A robust and fast clustering method for amplicon-based studies
GNU Affero General Public License v3.0
121 stars 23 forks source link

magic value? #154

Closed frederic-mahe closed 3 years ago

frederic-mahe commented 4 years ago

in search16.cc, line 144:

#if 0
void dprofile_dump16(WORD * dprofile)
{
  printf("\ndprofile:\n");
  for(int i=0; i<32; i++)
    {
      printf("%c: ", sym_nt[i]);
      for(auto k=0u; k<CDEPTH; k++)
        {
          printf("[");
          for(auto j=0u; j<CHANNELS; j++)
            printf(" %3d", (short) dprofile[CHANNELS*CDEPTH*i + CHANNELS*k + j]);
          printf("]");
        }
      printf("\n");
    }
  exit(1);
}
#endif

should the value 32 in for(int i=0; i<32; i++) be a variable? or the product CHANNELS * CDEPTH?

frederic-mahe commented 3 years ago

I think I am going to remove that function when I'll work on the warnings coming from the search files. Yell if you disagree :-)

torognes commented 3 years ago

Removed in commit 034557d725d02e8df74c132edf268c0741845af6.