search

torognes / vsearch

Versatile open-source tool for microbiome analysis
Other
656 stars 122 forks source link

Potentially incorrect results on ppc64le with usearch_global #456

Closed torognes closed 3 years ago

torognes commented 3 years ago

An issue have been reported to the Debian bug tracking system regarding vsearch on the ppc64le architecture:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=982139

It seems to affect at least usearch_global with vsearch 2.15.1 on Linux on ppc64le.

torognes commented 3 years ago

I have been able to reproduce this issue on an IBM OpenPower system running Linux on ppc64le, with the precompiled executable distributed with release version 2.17.1 (cross-compiled). However it does not appear with the precompiled version 2.15.1. Compiling locally with a native compiler also resolves the issue. Seems like it depends on the compiler used...

torognes commented 3 years ago

The bug appeared only when any optimisation was turned on and could be tracked down to the cpu.cc source file. The bug was found to be due to compiler optimisation of code where I had used an illegal pointer conversion. Sorry for that one. Fixed now.

torognes commented 3 years ago

I'll release a new version later today with this fix.

torognes commented 3 years ago

Fixed in release 2.18.0.