search

toroidal-code / cycle-themes.el

Because switching between your themes shouldn't be so damn hard
25 stars 9 forks source link

C-c C-t goes against key binding conventions #3

Open patrickeganfoley opened 6 years ago

patrickeganfoley commented 6 years ago

Hi @toroidal-code ! Thanks for writing this - it's a terrific package!

I had some difficulty with a conflict between cycle-themes and org-todo both wanting to control C-c C-t. It's solvable by editing the cycle_themes.el directly, but I think the C-c C-t binding goes against the key binding conventions.

It says

Sequences consisting of C-c followed by a control character or a digit are reserved for major modes.

and

Sequences consisting of C-c followed by any other ASCII punctuation or symbol character are allocated for minor modes. Using them in a major mode is not absolutely prohibited, but if you do that, the major mode binding may be shadowed from time to time by minor modes.

Could we consider changing the default cycle-themes binding? C-c . would work.

Thanks!

waymondo commented 5 years ago

I'd also chime in and agree with this. It globally overrides the binding for (org-todo) as one example, which is a common command for org-mode users.

An easy compromise might be to make cycle-themes-mode-map an actual variable, so users can override the theme cycling command to their preference.

buhtz commented 2 years ago

Do I see it correct that it is fixed and commited? Then this can be closed?

runejuhl commented 2 years ago

@Codeberg-AsGithubAlternative-buhtz it's fixed in https://github.com/toroidal-code/cycle-themes.el/pull/8, not sure why I didn't make a PR back in February 2020.