search

toronto-ruby / toronto-ruby.com

Toronto Ruby's website
https://toronto-ruby.com/
0 stars 2 forks source link

Add ics integration for events and add events show page #42

Closed marcoroth closed 1 month ago

marcoroth commented 1 month ago

This pull request adds a ics calendar for the all action in the EventsController. This publishes the following calendar:

URL  Description
https://toronto-ruby.com/events/all.ics All Events

The main motivation for this is to automate the import for meetups into https://rubyconferences.org/meetups via this pull request https://github.com/ruby-conferences/ruby-conferences.github.io/pull/735.

Since we always need a unique URL to point to for the event: I created a events#show action that just renders the existing _event.html.erb partial. I extracted the events/_layout.html.erb partial as well, so we can share the styles between the different event pages.

Let me know if you want me to tweak something.

/cc @crespire

Resolves https://github.com/toronto-ruby/toronto-ruby.com/issues/33

crespire commented 1 month ago

@marcoroth Thanks for doing this! I'll see if I can pull it down and check it out locally this weekend. The changes look good at first glance!

marcoroth commented 1 month ago

Awesome, thank you! 🙌🏼

marcoroth commented 1 month ago

Okay, this should be ready to go from my side! 🙌🏼

crespire commented 1 month ago

@marcoroth Have some test failures on CI, but otherwise looks good.

marcoroth commented 1 month ago

It's weird, they are passing fine in my fork: https://github.com/marcoroth/toronto-ruby.com/actions/runs/10703795088/job/29675183269

crespire commented 1 month ago

It's weird, they are passing fine in my fork: https://github.com/marcoroth/toronto-ruby.com/actions/runs/10703795088/job/29675183269

Looks like your latest changes did the trick! Thanks for putting this together!