1.8.0: pytest is failing

[kloczek]

Just normal build, install and test cycle used on building package from non-root account:

• "setup.py build"
• "setup.py install --root </install/prefix>"
• "pytest with PYTHONPATH pointing to setearch and sitelib inside </install/prefix>

• PYTHONPATH=/home/tkloczko/rpmbuild/BUILDROOT/python-stem-1.8.0-13.fc35.x86_64/usr/lib64/python3.8/site-packages:/home/tkloczko/rpmbuild/BUILDROOT/python-stem-1.8.0-13.fc35.x86_64/usr/lib/python3.8/site-packages
• PYTHONDONTWRITEBYTECODE=1
• /usr/bin/pytest -ra =========================================================================== test session starts ============================================================================ platform linux -- Python 3.8.9, pytest-6.2.4, py-1.10.0, pluggy-0.13.1 benchmark: 3.4.1 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000) rootdir: /home/tkloczko/rpmbuild/BUILD/stem-1.8.0 plugins: forked-1.3.0, shutil-1.7.0, virtualenv-1.7.0, expect-1.1.0, httpbin-1.0.0, flake8-1.0.7, timeout-1.4.2, betamax-0.8.1, freezegun-0.4.2, case-1.5.3, isort-1.3.0, aspectlib-1.5.2, asyncio-0.15.1, toolbox-0.5, xprocess-0.17.1, aiohttp-0.3.0, checkdocs-2.7.0, mock-3.6.1, rerunfailures-9.1.1, requests-mock-1.9.3, cov-2.12.1, pyfakefs-4.5.0, cases-3.6.1, flaky-3.7.0, hypothesis-6.14.0, benchmark-3.4.1, xdist-2.3.0, Faker-8.8.1 collected 2 items / 1 error / 1 selected

================================================================================== ERRORS ================================================================================== ____ ERROR collecting docs/_static/example/load_test.py ____ /usr/lib/python3.8/site-packages/_pytest/python.py:578: in _importtestmodule mod = import_path(self.fspath, mode=importmode) /usr/lib/python3.8/site-packages/_pytest/pathlib.py:524: in import_path importlib.import_module(module_name) /usr/lib64/python3.8/importlib/init.py:127: in import_module return _bootstrap._gcd_import(name[level:], package, level)

:1014: in _gcd_import ??? :991: in _find_and_load ??? :975: in _find_and_load_unlocked ??? :671: in _load_unlocked ??? /usr/lib/python3.8/site-packages/_pytest/assertion/rewrite.py:161: in exec_module source_stat, co = _rewrite_test(fn, self.config) /usr/lib/python3.8/site-packages/_pytest/assertion/rewrite.py:354: in _rewrite_test tree = ast.parse(source, filename=fn_) /usr/lib64/python3.8/ast.py:47: in parse return compile(source, filename, mode, flags, E File "/home/tkloczko/rpmbuild/BUILD/stem-1.8.0/docs/_static/example/load_test.py", line 22 E print '%0.1f%% (%s)' % (sum(samplings) / len(samplings) * 100, stem.util.str_tools.time_label(time.time() - start_time)) E ^ E SyntaxError: invalid syntax ========================================================================= short test summary info ========================================================================== ERROR docs/_static/example/load_test.py !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! ============================================================================= 1 error in 0.52s ============================================================================= ```

[kloczek]

OK I see that here is custom testing procedure .. nevertheless I think that it would be good to move to pytest only because pytest has a lot of extensions which allow test and scan code using vast number of pytest extension.

[atagar]

Hi kloczek, please see the following for how to test. I don't plan to move us to pytest.

https://stem.torproject.org/faq.html#how-do-i-run-the-tests

[kloczek]

That is fine however still it would be good fix stem code to allow use pytest because it has many extensions which allows not only test the code over some test units but as well scan and sanitize the code. From that point of view what offers pytest is way beyond what is now implemented in your test suite.

[atagar]

it has many extensions which allows not only test the code over some test units but as well scan and sanitize the code

What specific, concrete benefit does pytest provide that we do not have right now?

[kloczek]

Just look on current list https://docs.pytest.org/en/latest/reference/plugin_list.html Are you sure that all that (or even half) is already supported by what does run_tests.py?

• format checking (black)
• codecheckers (sanity checker)
• test unit order randomisation (like pytest-random) .. many test units are failing when they used in random order (sometimes by bugs in tested code)

and many, many more ..