search

torproject / stem

Python controller library for Tor
https://stem.torproject.org/
GNU Lesser General Public License v3.0
257 stars 75 forks source link

for issue #116 #122

Closed 0-harshit-0 closed 1 year ago

0-harshit-0 commented 2 years ago

added functionality to connect using URL

atagar commented 2 years ago

Hi harshit, sorry for the long delay. This is a fine attempt but has some issues...

  1. It breaks both method's pydocs. The first comment block of a method is special in that Sphinx uses it to generate API documentation.
  2. Rather than allowing hostnames for the address argument it would be better if we added a new 'hostname' argument. This way the argument isn't a misnomer and can't accidently trigger a DNS lookup (which could leak data in some environments).
  3. This change would require unit and integ test coverage.
0-harshit-0 commented 2 years ago

oh ok got it.

0-harshit-0 commented 2 years ago

hello, I have made a new commit to this pull request.

atagar commented 1 year ago

It's been a while without tests being added so closing.