search

torproject / stem

Python controller library for Tor
https://stem.torproject.org/
GNU Lesser General Public License v3.0
273 stars 76 forks source link

Development version is lower than released version #123

Open jorti opened 2 years ago

jorti commented 2 years ago

I've published latest git commit in Fedora rawhide to pick the fixes related to Python 3.11, however I've discovered that the development version 1.8.0-dev is considered lower than 1.8.0, causing dependency problems on other packages that require stem >= 1.8.0, see the Fedora bug: https://bugzilla.redhat.com/show_bug.cgi?id=2101749

The version was changed in commit https://github.com/torproject/stem/commit/4fd458d4debf2444023de9f745ce726f84da79cf

The development releases are ordered before the final release, see:

https://peps.python.org/pep-0440/#developmental-releases

Please, consider updating the version to 1.8.1-dev or similar. Thank you.

atagar commented 2 years ago

Hi Juan. Stem 1.8.0 is the latest release and I don't have any plans on making future ones. That said, if Stem development resumes I'd be happy to adjust how we tag between releases.

jorti commented 2 years ago

Hi, the problem with the current dev version is that it has jumped backwards. Maybe using something like 1.8.0-post-dev ?

If this isn't fixed, I'll need to patch the version number downstream. Thanks.

jorti commented 2 years ago

Well, it turns out that 1.8.0-post-dev is not ordered after 1.8.0-dev as I was expecting.

I'm patching the version to 1.8.1-dev downstream to fix the dependency problem.

kloczek commented 2 years ago

@atagar what about fliush alredy commited changes as new release? 🤔 https://github.com/torproject/stem/compare/1.8.0...master

atagar commented 2 years ago

Stem's master branch is far from a stable state for a release. At the very least #77 would need to be addressed.

emdee-is commented 7 months ago

In stem/init.py it says

__version__ = '1.8.0-dev'

The latest version shipping with gentoo and debian is 1.8.2

Please bump this ASAP to at least 1.8.3 so that we can make use of the git repo.

atagar commented 7 months ago

Again, you seem to be referencing the master branch. Do NOT package that for Gentoo. If the version has a '-dev' suffix then you're using the wrong thing. ;)

emdee-is commented 7 months ago

Ooops - nice to know. Could you put a note on this in the README? I thought master on github was expected to be the current branch unless noted in the README. There are a lot of differennces on maint so now the maint->gitlab differences are a big divergence.