setup.py needs cleanup - Githubissues

torproject / stem

Python controller library for Tor

https://stem.torproject.org/

GNU Lesser General Public License v3.0

260 stars 75 forks source link

setup.py needs cleanup #43

Closed atagar closed 4 years ago

atagar commented 4 years ago

Migrated from ticket 31234.

We should avoid importing our own modules as this prevents us from being installed from other directories.
Optionally use setuptools so bdist_wheel can be available.

msramalho commented 4 years ago

Hey @atagar, I will be trying to fix this.

I have found a very interesting page that gives several options to solve this. Can you please take a look and check which would make more sense?

In the meantime, I have migrate distutils to setuptools in #58

msramalho commented 4 years ago

By the way, the original ticket mentioned:

All the large strings should be in separate files. Should this also be fixed? if so, what's the criteria to use when telling which strings to isolate to a file?

atagar commented 4 years ago

Thanks Miguel! Pushed along with some test fixes.

As for getting the package version thanks for pointing that out! We actually previously did the first option, so we could probably simply revert this to do that.

msramalho commented 4 years ago

Hey @atagar, thanks for the tips, I have adapted the previous code and submitted another PR.

atagar commented 4 years ago

Thanks Miguel! Merged.