torproject / torbrowser-launcher

Securely and easily download, verify, install, and launch Tor Browser in Linux. This repository is a mirror of https://gitlab.torproject.org/tpo/applications/torbrowser-launcher
MIT License
789 stars 185 forks source link

Pickle load fails #389

Open CatusB opened 5 years ago

CatusB commented 5 years ago

I was using v0.1.9 for Debian Jessie. Migrated to Stretch and v0.3.1. By running torbrowser-launcher I get:

Tor Browser Launcher
By Micah Lee, licensed under MIT
version 0.3.1
https://github.com/micahflee/torbrowser-launcher
Traceback (most recent call last):
  File "/usr/bin/torbrowser-launcher", line 30, in <module>
    torbrowser_launcher.main()
  File "/usr/lib/python3/dist-packages/torbrowser_launcher/__init__.py", line 72, in main
    common = Common(tor_browser_launcher_version)
  File "/usr/lib/python3/dist-packages/torbrowser_launcher/common.py", line 64, in __init__
    self.load_settings()
  File "/usr/lib/python3/dist-packages/torbrowser_launcher/common.py", line 313, in load_settings
    self.settings = pickle.load(open(self.paths['settings_file_pickle']))
TypeError: a bytes-like object is required, not 'str'

Conversion from old format fails. Line 313 should be: self.settings = pickle.load(open(self.paths['settings_file_pickle'], 'rb'))

Dolomich commented 4 days ago

I had the same problem, turns out the old config file in ~/.config/torbrowser/ was causing it, deleting it allowed the launcher to work