torpyorg / torpy

Pure python Tor client implementation
Apache License 2.0
403 stars 48 forks source link

Receive request_context parameter #4

Closed tribela closed 4 years ago

tribela commented 4 years ago

This PR fixes this error:

  File "/home/arm/.virtualenvs/ani.work/lib/python3.7/site-packages/requests/sessions.py", line 546, in get
    return self.request('GET', url, **kwargs)
  File "/home/arm/.virtualenvs/ani.work/lib/python3.7/site-packages/requests/sessions.py", line 533, in request
    resp = self.send(prep, **send_kwargs)
  File "/home/arm/.virtualenvs/ani.work/lib/python3.7/site-packages/requests/sessions.py", line 646, in send
    r = adapter.send(request, **kwargs)
  File "/home/arm/.virtualenvs/ani.work/lib/python3.7/site-packages/requests/adapters.py", line 412, in send
    conn = self.get_connection(request.url, proxies)
  File "/home/arm/.virtualenvs/ani.work/lib/python3.7/site-packages/requests/adapters.py", line 315, in get_connection
    conn = self.poolmanager.connection_from_url(url)
  File "/home/arm/.virtualenvs/ani.work/lib/python3.7/site-packages/urllib3/poolmanager.py", line 287, in connection_from_url
    u.host, port=u.port, scheme=u.scheme, pool_kwargs=pool_kwargs
  File "/home/arm/.virtualenvs/ani.work/lib/python3.7/site-packages/urllib3/poolmanager.py", line 234, in connection_from_host
    return self.connection_from_context(request_context)
  File "/home/arm/.virtualenvs/ani.work/lib/python3.7/site-packages/urllib3/poolmanager.py", line 247, in connection_from_context
    return self.connection_from_pool_key(pool_key, request_context=request_context)
  File "/home/arm/.virtualenvs/ani.work/lib/python3.7/site-packages/urllib3/poolmanager.py", line 269, in connection_from_pool_key
    pool = self._new_pool(scheme, host, port, request_context=request_context)
TypeError: _new_pool() got an unexpected keyword argument 'request_context'
jbrown299 commented 4 years ago

Thanks for pointing out. This is probably because you using requests 2.14 or so. I've added more compatibility (see https://github.com/torpyorg/torpy/commit/d2eba2026b8631bd53a580bf9b026957f3ac16e5) with requests library (now from 2.9 to latest version), but anyway try new urllib tor_opener.