search

torque59 / Nosql-Exploitation-Framework

A Python Framework For NoSQL Scanning and Exploitation
BSD 3-Clause "New" or "Revised" License
595 stars 157 forks source link

Constructive feedback #3

Open dermorz opened 9 years ago

dermorz commented 9 years ago

Came here from: https://www.reddit.com/r/netsec/comments/3g4mr2/nosql_exploitation_framework_v20/

  1. Try to stick to PEP8.
  2. Throw away the install.sh. This is a terrible way of installing python software, because it pollutes existing python installations with modules I would no want there and especially because it can't be installed as a user that way. Instead create a requirements.txt with the needed modules, so it's easy to create a virtualenv to run the frameworkscript. Or even better:
  3. Read up on packaging and distributing python projects and take the necessary steps. After that someone could easily install your framework via pip install nosqlexploitationframework.

Furthermore: Replace your cleanup.sh with a .gitignore file.

torque59 commented 9 years ago

Hey,Thanks for bringing to my notice @moritzpein

Many thanks for the suggestions , and looking forward for more feedback :+1: