search

torrancew / puppet-cron

Puppet module to manage cron jobs via /etc/cron.d
Other
37 stars 49 forks source link

Multi commands #26

Closed ghost closed 8 years ago

ghost commented 10 years ago

As we are managing multiple cronjobs in a large application, it's more manageable to create one cronjob file with multiple times/commands instead of one cron file per time/command.

This code is a rough draft: it could be tweaked to set default values for empty hash parameters (minutes, hours, etc) and some ideas you might have!

So if this feature is useful to you, I could spend more time improving it.

Have fun!

torrancew commented 10 years ago

@svigneux Thoroughly apologize for taking so long on this. I'd love to get it merged in. If you could help by filling in some specs for it, that'd be great - otherwise I'll get to it when I can!

torrancew commented 8 years ago

@svigneux i don't know if you still have this code, but I'm trying to restore these projects to the level of usefulness they once had (and exceed it), and frankly, this is the most well-formed, considerate pull request I've ever received. I'm ashamed I didn't pull this in before the branch was deleted. If not, I can pull it together from the diffs visible here, but I thought I'd check!

ghost commented 8 years ago

Hi @torrancew, we all have a lot of things to do, it's normal to forget (I do too, quite often actually).

We've migrated to rmueller-cron which is a fork of your puppet module. It has cron::job::multiple which is a very similar define. Perhaps it would be best to merge this module instead of my old hackish version.

torrancew commented 8 years ago

Thanks, opened https://github.com/roman-mueller/rmueller-cron/issues/9 for that!