search

torrancew / puppet-cron

Puppet module to manage cron jobs via /etc/cron.d
Other
37 stars 49 forks source link

fixes for future parser - mode must now be a string #32

Closed CpuID closed 8 years ago

CpuID commented 10 years ago

without this, a deprecation warning is output

Warning: Non-string values for the file mode property are deprecated. It must be a string, either a symbolic mode like 'o+w,a+r' or an octal representation like '0644' or '755'. (at /usr/local/rbenv/versions/1.9.3-p484/lib/ruby/gems/1.9.1/gems/puppet-3.7.3/lib/puppet/type/file/mode.rb:69:in `block (2 levels) in module:Puppet')

bastelfreak commented 9 years ago

Hi, would it be possible to release a new version including this fix? Otherwise it is not possible to use this module with the current version of Puppet.

CpuID commented 9 years ago

+1

bump @torrancew

roman-mueller commented 9 years ago

+1 with Puppet 4 released future parser is now the default and this module broken.

pecastro commented 9 years ago

+1 Come on ... it's a simple merge ...

queeno commented 9 years ago

Please merge +1

dudemcbacon commented 9 years ago

Would be awesome if we could get this merged!

roman-mueller commented 9 years ago

At this point I consider this repository abandoned. To not block me from migrating to Puppet 4 I have forked it and also released the fork on forge (https://forge.puppetlabs.com/rmueller/cron) - including this change of course. Maybe it helps someone else too.

torrancew commented 8 years ago

Apologies to all I have let down. Maintaining this module became unfeasible for a while, due to changes in employment, but is now viable again. Due to the many related pull requests, I found it much simpler to go ahead and fix the open issues directly, and have also updated Travis to test the most recent versions of 2.7, 3.8 and 4.4 against Rubies 1.8.7, 1.9.3, 2.0, 2.1 and 2.2. Some combinations are expected to fail due to Puppet's own compatibility requirements, but the tests are now in a good state. I'll be closing pull requests that were already fixed, or are not viable currently (due to being unmergeable, etc), but do feel free to engage this project going forward.