Open GoogleCodeExporter opened 9 years ago
Hi
I have the issue in Caller id on Sipml5 client side
When calling from sipml5 to and sip phone like zoiper, It shows the caller Id
calling. But in case of call from any sip phone to Sipml5 client it only shows
"incomming call from User name" there is no caller id there.
Also same when make call between two sipml5 clients, there is no caller id .
Original comment by mfurqan...@gmail.com
on 27 Jan 2015 at 10:13
Hello guys,
I've formulated a temporary hack that will fix this problem (At least with
Asterisk), see below on how to apply it. I believe the problem is clone() (in
tsip_session.prototype.__set) is called with 'false,false' when it should be
'false,true', but the problem with making the 2nd argument true is
tsip_uri.prototype.Parse() won't be able to decipher it, so until
tsip_uri.prototype.Parse is patched to add the ability to parse the name from
the formatted sip uri (Which would be like: "Display Name"<sip:123@domain.com>)
the display name will keep being dropped. An alternative to adding display name
parsing logic is we could give Parse() a second argument that would just be the
display name (defaults to null), and let it directly carry that over to the new
URI object.
To fix incoming caller ID (Minified JS):
Find: this.o_uri_from=b.o_hdr_From.o_uri.clone(false,false)
Add after: ;this.o_uri_from.s_display_name=b.o_hdr_From.s_display_name
To fix incoming caller ID (Normal JS @ tinySIP/src/tsip_session.js):
Find: this.o_uri_from = o_message.o_hdr_From.o_uri.clone(false, false);
Add this line after: this.o_uri_from.s_display_name =
o_message.o_hdr_From.s_display_name;
After this fix you should be able to format a nice caller ID (Tested both
external and internal calls):
var callerID = e.newSession.o_session.o_uri_from.s_display_name + ' <' +
e.newSession.o_session.o_uri_from.s_user_name + '>';
Original comment by CraigShe...@gmail.com
on 4 Feb 2015 at 5:14
Original issue reported on code.google.com by
j...@fluentstream.com
on 7 Mar 2014 at 8:09