torressa / cspy

A collection of algorithms for the (Resource) Constrained Shortest Path problem in Python / C++ / C#
https://torressa.github.io/cspy/
MIT License
77 stars 24 forks source link

Revert to v0.1.1 with new features (Sourcery refactored) #50

Closed sourcery-ai[bot] closed 3 years ago

sourcery-ai[bot] commented 3 years ago

Pull Request #49 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will re-run and update (force-push) this Pull Request with new refactorings as necessary. If Sourcery finds no refactorings at any point, this Pull Request will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the patch43-v0.1.1 branch, then run:

git fetch origin sourcery/patch43-v0.1.1
git merge --ff-only FETCH_HEAD
git reset HEAD^
sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report (beta)

✅ Merging this PR will increase code quality in the affected files by 0.02 out of 10.

Before After Change
Quality 8.12 8.14 0.02
Complexity 4.74 4.59 -0.15
Method Length 61.58 61.32 -0.26
Lines 554 547 -7
Changed files Quality Before Quality After Quality Change
cspy/algorithms/bidirectional.py 7.88 7.9 0.02 ⬆️
cspy/algorithms/label.py 8.69 8.71 0.02 ⬆️

Here are some functions in these files that still need a tune-up:

File Function Quality Recommendation
cspy/algorithms/bidirectional.py BiDirectional._get_direction 4.0 Split out functionality
cspy/algorithms/label.py Label.get_new_label 5.77 Split out functionality
cspy/algorithms/bidirectional.py BiDirectional.__init__ 6.33 Split out functionality

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it via email or our Gitter!

codecov[bot] commented 3 years ago

Codecov Report

Merging #50 into patch43-v0.1.1 will increase coverage by 0.09%. The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           patch43-v0.1.1      #50      +/-   ##
==================================================
+ Coverage           92.74%   92.83%   +0.09%     
==================================================
  Files                  24       24              
  Lines                1598     1591       -7     
==================================================
- Hits                 1482     1477       -5     
+ Misses                116      114       -2     
Impacted Files Coverage Δ
cspy/algorithms/bidirectional.py 93.42% <100.00%> (+0.71%) :arrow_up:
cspy/algorithms/label.py 95.52% <100.00%> (-0.13%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b0427e1...f94859f. Read the comment docs.