sourcery-ai[bot]
commented
3 years ago Sourcery Code Quality Report
❌ Merging this PR will decrease code quality in the affected files by 0.21%.
| Quality metrics | Before | After | Change |
|---|---|---|---|
| Complexity | 2.13 ⭐ | 1.78 ⭐ | -0.35 👍 |
| Method Length | 52.14 ⭐ | 54.06 ⭐ | 1.92 👎 |
| Working memory | 8.26 🙂 | 8.31 🙂 | 0.05 👎 |
| Quality | 75.17% ⭐ | 74.96% 🙂 | -0.21% 👎 |
| Other metrics | Before | After | Change |
|---|---|---|---|
| Lines | 425 | 444 | 19 |
| Changed files | Quality Before | Quality After | Quality Change |
|---|---|---|---|
| docs/conf.py | 91.89% ⭐ | 83.21% ⭐ | -8.68% 👎 |
| src/python/algorithms/bidirectional.py | 63.37% 🙂 | 65.04% 🙂 | 1.67% 👍 |
| test/python/tests_bidirectional.py | 80.30% ⭐ | 80.30% ⭐ | 0.00% |
| test/python/tests_issue32.py | 76.52% ⭐ | 75.29% ⭐ | -1.23% 👎 |
| test/python/tests_issue41.py | 78.46% ⭐ | 78.46% ⭐ | 0.00% |
Here are some functions in these files that still need a tune-up:
| File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
|---|---|---|---|---|---|---|
| src/python/algorithms/bidirectional.py | BiDirectional.__init__ | 13 🙂 | 204 😞 | 18 ⛔ | 34.88% 😞 | Try splitting into smaller methods. Extract out complex expressions |
| test/python/tests_issue32.py | TestsIssue32.setUp | 0 ⭐ | 172 😞 | 8 🙂 | 65.02% 🙂 | Try splitting into smaller methods |
| test/python/tests_issue41.py | TestsIssue41.setUp | 0 ⭐ | 134 😞 | 8 🙂 | 68.96% 🙂 | Try splitting into smaller methods |
Legend and Explanation
The emojis denote the absolute quality of the code:
- ⭐ excellent
- 🙂 good
- 😞 poor
- ⛔ very poor
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Let us know what you think of it by mentioning @sourcery-ai in a comment.
Re-structured the implementation to investigate #66.
Turns out it was actually fine (some minor bugs) but the coordination mechanism between searches was very expensive, so by merging all the functionality, we have a ugly but fast version.