search

torrust / torrust-index-gui

This repository serves as the frontend for the Torrust Index project.
https://torrust.com
Other
32 stars 16 forks source link

fix:[#537] add --max-warnings=0 to package.json #544

Closed hungfnt closed 5 months ago

hungfnt commented 5 months ago

I'm not able to test it.

josecelano commented 5 months ago

Hi @ngthhu I normally test these things with npm run lint && echo "OK".

If you see the "OK", the previous command didn't return an error code. ESLint returns an error with the new option.

npm run lint && echo "OK"

> lint
> eslint --ext ".ts,.js,.vue" . --max-warnings=0

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=4.3.5 <5.4.0

YOUR TYPESCRIPT VERSION: 5.4.3

Please only submit bug reports when using the officially supported version.

=============

/home/josecelano/Documents/git/committer/me/github/torrust/torrust-index-gui/components/Breadcrumb.vue
  9:56  warning  Expected no space before '>', but found  vue/html-closing-bracket-spacing

✖ 1 problem (0 errors, 1 warning)
  0 errors and 1 warning potentially fixable with the `--fix` option.

ESLint found too many warnings (maximum: 0).
josecelano commented 5 months ago

ACK 2251ba03092a368cafb9b8895f524f526b27c04c

josecelano commented 5 months ago

Another suggestion. We usually prefer rebasing rather than merging. In other projects, we force a linear history.