search

torrust / torrust-index-gui

This repository serves as the frontend for the Torrust Index project.
https://torrust.com
Other
32 stars 16 forks source link

add spinner gif to display instead of No results while data is loading #573

Open grmbyrn opened 5 months ago

grmbyrn commented 5 months ago

I added spinner.gif to torrents.vue to display instead of No results, which currently flashes on the screen when torrents are being loaded as mentioned here.

<span data-cy="no-results-element" class="text-neutral-content flex items-center justify-center">
  <img src="/spinner.gif" class="w-20 h-20" alt="Loading Spinner">
</span>
grmbyrn commented 5 months ago

HI @grmbyrn I think this solves a different problem now.

The issue #411 was solved here.

Anyway, this PR is still useful because you see the spinner while the app is getting the list from the API. Althougth, that should be fast.

We can merge it but some E2E tests are failing.

Hi @josecelano I realised after I'd made the PR that this was referring to another part of the app, but I was seeing 'No results.' flash on my screen while it was getting the list so thought the spinner would suit there.

As for the E2E tests, I've been going through it and trying to find a solution but new errors keep coming up. I haven't done much E2E so maybe it's just something I need to look at more.

grmbyrn commented 5 months ago

HI @grmbyrn I think this solves a different problem now.

The issue #411 was solved here.

Anyway, this PR is still useful because you see the spinner while the app is getting the list from the API. Althougth, that should be fast.

We can merge it but some E2E tests are failing.

Hi @josecelano the E2E tests seem to be passing now that I changed no_torrents_to_display.cy.ts to expect an image and not text.