torrust / torrust-tracker

A modern and feature-rich (private) BitTorrent tracker.
https://torrust.com
GNU Affero General Public License v3.0
339 stars 40 forks source link

Config overhaul: lowercase for `DatabaseDriver` #953

Closed josecelano closed 3 days ago

josecelano commented 3 days ago

Use lowercase for database driver values in the configuration:

[core.database]
driver = "sqlite3"
#driver = "MySQL"

Instead of:

[core.database]
driver = "Sqlite3"
#driver = "MySql"

We are normalizing all enum variants in the configuration to lowercase.

It also decouples the internal database driver enum from the enum used in the configuration.

josecelano commented 3 days ago

ACK ca348a839867ec56a66b0ce8abfd714d7633ede8

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 59.25926% with 11 lines in your changes missing coverage. Please review.

Project coverage is 77.31%. Comparing base (c747321) to head (ca348a8).

Files Patch % Lines
src/core/databases/error.rs 18.18% 9 Missing :warning:
src/core/databases/driver.rs 75.00% 1 Missing :warning:
src/core/mod.rs 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #953 +/- ## =========================================== - Coverage 77.31% 77.31% -0.01% =========================================== Files 183 183 Lines 9731 9735 +4 =========================================== + Hits 7524 7527 +3 - Misses 2207 2208 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.