torrust / torrust-tracker

A modern and feature-rich (private) BitTorrent tracker.
https://torrust.com
GNU Affero General Public License v3.0
357 stars 40 forks source link

Disable `TimeoutAcceptor` when TSL is enabled #954

Closed josecelano closed 1 month ago

josecelano commented 3 months ago

The TimeoutAcceptor es a custom acceptor for Axum that sets a timeput for making a request after openning a connection.

It does not work when TSL is enabled.

This commit disables it, therefore the app does not have any way to avoid a DDos attacks where clients just open connections without making any request.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.10%. Comparing base (0a04dde) to head (222fa42).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #954 +/- ## =========================================== - Coverage 77.14% 77.10% -0.04% =========================================== Files 185 185 Lines 10058 10063 +5 =========================================== Hits 7759 7759 - Misses 2299 2304 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

da2ce7 commented 2 months ago

ACK 38bb7cda90090292daf88717b6516e8854329095

josecelano commented 1 month ago

ACK 222fa42ee0bf8674bb2b2ec639ed2fdcf8b02763

josecelano commented 1 month ago

ACK 38bb7cd

I forgot to merge this.