torrust / torrust-website

Public Website for Torrust Organisation
https://torrust.com
GNU General Public License v3.0
2 stars 4 forks source link

Migrate from Svelte 4 to Svelte 5 #106

Open grmbyrn opened 3 weeks ago

grmbyrn commented 3 weeks ago

With the release of Svelte 5, it's a good time to migrate from Svelte 4. The benefits of Svelte 5 include:

da2ce7 commented 3 weeks ago

Hello @grmbyrn What of these enhancements of Svelte 5 provides benefits for our project?

grmbyrn commented 3 weeks ago

Hello @grmbyrn What of these enhancements of Svelte 5 provides benefits for our project?

Hi @da2ce7 I'm still digging into the changes but the big enhancements for us that I see so far are:

grmbyrn commented 3 weeks ago

@histoire/plugin-svelte@0.17.17 has a strict peer dependency on svelte@^3.0.0 || ^4.0.0, and cannot resolve svelte@5.1.5. This is the main reason for the ERESOLVE conflict:

npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @histoire/plugin-svelte@0.17.17
npm error Found: svelte@5.1.5
npm error node_modules/svelte
npm error   peer svelte@">4.0.0" from @iconify/svelte@4.0.2
npm error   node_modules/@iconify/svelte
npm error     dev @iconify/svelte@"^4.0.2" from the root project
npm error   peer svelte@"^4.0.0 || ^5.0.0-next.0" from @sveltejs/kit@2.7.3
npm error   node_modules/@sveltejs/kit
npm error     peer @sveltejs/kit@"^2.0.0" from @sveltejs/adapter-static@3.0.1
npm error     node_modules/@sveltejs/adapter-static
npm error       dev @sveltejs/adapter-static@"^3.0.1" from the root project
npm error     dev @sveltejs/kit@"^2.5.27" from the root project
npm error   6 more (eslint-plugin-svelte, prettier-plugin-svelte, ...)
npm error
npm error Could not resolve dependency:
npm error peer svelte@"^3.0.0 || ^4.0.0" from @histoire/plugin-svelte@0.17.17
npm error node_modules/@histoire/plugin-svelte
npm error   dev @histoire/plugin-svelte@"^0.17.17" from the root project
npm error
npm error Conflicting peer dependency: svelte@4.2.19
npm error node_modules/svelte
npm error   peer svelte@"^3.0.0 || ^4.0.0" from @histoire/plugin-svelte@0.17.17
npm error   node_modules/@histoire/plugin-svelte
npm error     dev @histoire/plugin-svelte@"^0.17.17" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /Users/macbookair/.npm/_logs/2024-10-30T18_33_29_085Z-eresolve-report.txt
npm error A complete log of this run can be found in: /Users/macbookair/.npm/_logs/2024-10-30T18_33_29_085Z-debug-0.log