search

torrust / torrust-website

Public Website for Torrust Organisation
https://torrust.com
GNU General Public License v3.0
1 stars 2 forks source link

fix issues with v2 #44

Closed grmbyrn closed 1 month ago

grmbyrn commented 1 month ago
josecelano commented 1 month ago

ACK 19437dd83738489a58ed7aff44560c954978ac69

grmbyrn commented 1 month ago

Good job @grmbyrn, just a couple of comments:

  1. I'm closing only the issues I consider finished 100%. I commented on the ones I think there are pending things to do.
  2. Make sure the linter passes before opening the PR and fix it if it fails after opening the PR.
  3. Make sure to follow the design as much as possible (pixel). I think it's very important to implement exactly what the designers gave us. They have their reasons and in my opinion the final site looks much worse with many mini changes.

That's no problem. For the linters, I ran them before and had no error. The error after opening the PR indicates an issue in Hero.svelte but nothing comes up when I check it.

josecelano commented 1 month ago

Good job @grmbyrn, just a couple of comments:

  1. I'm closing only the issues I consider finished 100%. I commented on the ones I think there are pending things to do.
  2. Make sure the linter passes before opening the PR and fix it if it fails after opening the PR.
  3. Make sure to follow the design as much as possible (pixel). I think it's very important to implement exactly what the designers gave us. They have their reasons and in my opinion the final site looks much worse with many mini changes.

That's no problem. For the linters, I ran them before and had no error. The error after opening the PR indicates an issue in Hero.svelte but nothing comes up when I check it.

In those cases you can run npm run format and check is there was a git change (git status). I don't know why it's not showing the error.

I guess you mean this:

image