torrvision / crayon

A language-agnostic interface to TensorBoard
MIT License
779 stars 59 forks source link

Exp name containing plus '+' sign does not work #26

Closed qizhuli closed 7 years ago

qizhuli commented 7 years ago

My experiment name is 'myexp+suffix'. When I call the add_scalar_value function for this experiment, I get the following error message:

Traceback (most recent call last):
  File "plot.py", line 126, in main
    crayon_experiment.add_scalar_value(key, values[key], step = counter)
  File "anaconda/lib/python2.7/site-packages/pycrayon/crayon.py", line 149, in add_scalar_value
    raise ValueError(msg.format(r.text))
ValueError: Something went wrong. Server sent: Unknown experiment name 'myexp suffix'.

It has dropped the + sign from the experiment name and complains experiment does not exist.

edran commented 7 years ago

We don't sanitise special characters (such as +). Feel free to fork it and write a PR that fixes it if you find the time :)

albanD commented 7 years ago

Fixed via #34