tors / jquery-fileupload-rails

jQuery File Upload integrated for Rails
669 stars 254 forks source link

Error during precompiling #10

Closed andoriyu closed 9 years ago

andoriyu commented 12 years ago

bundle exec rake assets:precompile 15:12:04 /Users/andoriyu/.rvm/rubies/ruby-1.9.3-p194/bin/ruby /Users/andoriyu/.rvm/gems/ruby-1.9.3-p194/bin/rake assets:precompile:all RAILS_ENV=production RAILS_GROUPS=assets rake aborted! Invalid CSS after "*": expected "{", was "html .fileinput..."

"html" may only be used at the beginning of a selector. (in /Users/andoriyu/Git/Ruby/sarp/app/assets/stylesheets/application.scss)

Tasks: TOP => assets:precompile:primary (See full trace by running task with --trace) rake aborted! Command failed with status (1): [/Users/andoriyu/.rvm/rubies/ruby-1.9.3-p19...]

Tasks: TOP => assets:precompile (See full trace by running task with --trace)

tors commented 12 years ago

@andoriyu hi Andrey! Have you tried renaming your application.css to application.css.scss ? Seemed to work before if I can remember correctly. I just recently made an example app for this gem. You may want to check this out https://github.com/tors/jquery-fileupload-rails-paperclip-example

andoriyu commented 12 years ago

@tors yes, it is already application.css.scss. Just removing fixes of IE worked for me.

veloper commented 12 years ago

+1 - This seems to be happening to my app as well -- exact same error.

Also changed to application.css.scss with no luck.

guigs commented 12 years ago

I had the same problem. It seems that it is something with sass gem version 3.2.0. To force using sass 3.1.x put in your Gemfile:

gem 'sass', '~> 3.1.0'
rlanvin commented 12 years ago

+1 The same error appeared after upgrading sass, and I can confirm @guigs fix worked.

virtualfunction commented 12 years ago

Yes, this is an issue for me, SASS 3.2 seems to be to blame

ep-wac commented 12 years ago

+1 SASS 3.2 either has tightened the DSL or something turned sour on them :)

@guigs is right - forcing 'sass' down works for me too

ethul commented 12 years ago

Updating lines 55 to 64 in the jquery.fileupload-ui.css.erb to the following seems to work on Sass 3.2.

/* Fix for IE 6: */
* html .fileinput-button {
  line-height: 22px;
  margin: 1px -3px 0 0;
}

/* Fix for IE 7: */
* + html .fileinput-button {
  margin: 1px 0 0 0;
}
wQwRtaufxJw7UFLCXzXz commented 12 years ago

any chance we can see if that fix still works for IE 7?

tylercollier commented 12 years ago

I had the same problem with sass 3.2.1. Reverting back to 3.1.21 worked for me.

poori commented 12 years ago

thanks. replacing the lines as mentioned by @ethul worked for me.

richkuo commented 12 years ago

hey @ethul, where is the jquery.fileupload-ui.css.erb file located?

ethul commented 12 years ago

hi @richkuo, this depends on how you have ruby install. The file will end up where you have your gems installed:

/path/to/your/ruby/gems/jquery-fileupload-rails-0.3.2/vendor/assets/stylesheets/jquery.fileupload-ui.css.erb

richkuo commented 12 years ago

@ethul thanks i forked over my own repo, made the changes, and explicitly called it in my Gemfile with gem 'jquery-fileupload-rails', :git => "git://github.com/richkuo/jquery-fileupload-rails"

zzet commented 12 years ago

hi @richkuo ! I also do this....

teddis commented 12 years ago

Thanks @ethul, worked great!

kevzettler commented 12 years ago

+1 for this issue

svasva commented 12 years ago

+1

sardaukar commented 12 years ago

+1

tmtysk commented 12 years ago

+1

zolzaya commented 11 years ago

+1

felixbuenemann commented 9 years ago

As written above: upgrade sass.