search

tors / jquery-fileupload-rails

jQuery File Upload integrated for Rails
669 stars 253 forks source link

Update assets to jQuery-File-Upload 9.8.0 #68

Closed opti closed 9 years ago

opti commented 9 years ago

This PR includes:

ipd commented 9 years ago

@opti I noticed your PR sitting here. So, is this gem currently unmaintained? Perhaps @tors has moved on or is too busy?

I'd like to use the gem, but am running Rails 4.1.x and am wondering what to do. Perhaps i should just use your fork?

thanks!

opti commented 9 years ago

@ipd yeah, the origin gem looks unmaintained for a while and I'm not sure it will be back on track. Anyway, I'm using my fork exactly with Rails 4.1.x. Didn't noticed any issues yet.

ipd commented 9 years ago

@opti ok, thanks for getting back to me.

tors commented 9 years ago

@opti Hola! Thanks for this! I've been very busy at work. I've added you as a collaborator.

ipd commented 9 years ago

Thanks @tors !

We should probably version the gem so that people who are on rails < 4.x will be able to continue to use the old version.

Also, we should create a new example app for Rails 4.x.

opti commented 9 years ago

Thanks for merging this @tors

opti commented 9 years ago

hey @tors I've created a release tag v0.4.2, if you don't mind you can push it to rubygems

tors commented 9 years ago

@opti roger that! Thanks!

felixbuenemann commented 9 years ago

You should probably add back the X-Requested-WIth Patch for the Iframe-Transport Middleware before making a new release, see commit d246fe6 for details.

opti commented 9 years ago

@felixbuenemann I'm not sure that this is a good idea to make those changes in that repo. This js file is copied from original repo. Making fixes here forces repo maintainers to always keep in mind this fix on every future assets upgrade. Maybe it make sense to open a pull request with this fix to the @blueimp's original jQuery-File-Upload repo.

felixbuenemann commented 9 years ago

Jepp, that's what I though and it was rejected, see blueimp/jQuery-File-Upload#3291. The problem is that this repo used to have this patch, so not having it brakes the usage of the iframe transport middleware.

Maybe the middleware could be changed to somehow detect the request without the extra header.

opti commented 9 years ago

@felixbuenemann I see. You're feel free to add it back while there is no another solution yet.

felixbuenemann commented 9 years ago

I think the best solution is to remove the middleware, see #69 for reasons.