search

torstenroeder / zefiro

Small Content Management Framework in PHP/MySQL
GNU Lesser General Public License v3.0
0 stars 1 forks source link

Missing constants #14

Closed Rillke closed 5 years ago

Rillke commented 5 years ago

Some constants aren't defined in the default config, nor is there a hint that they should be defined.

torstenroeder commented 5 years ago

They should be imported from the translation files.

torstenroeder commented 5 years ago

It should actually not occur that one of these is used before a translation set is loaded.

Rillke commented 5 years ago

A search, e.g. for DBI_DATABASE_STATUS only returns use of those constants but no definitions. Where are the language files supposed to live in? Do they have to be created by the server admin?

torstenroeder commented 5 years ago

I have replaced the prefix DBI by Z (DBI was deprecated).

torstenroeder commented 5 years ago

Where does Z_SEPARATOR_SYMBOL occur?

Rillke commented 5 years ago

Where does Z_SEPARATOR_SYMBOL occur?

689920201e919e46 accidentally added that constant to custom/config.default.php

Rillke commented 5 years ago

I notice there are still DBI_ constants defined in custom/config.default.php.

torstenroeder commented 5 years ago

this should work much better now. L => localization constants, Z => zefiro system constants. we should consider some more prefixes to make it clearer.

torstenroeder commented 5 years ago

If any constant is still missing somewhere, it can be done as quickfix. Closed.