tortellini-tools / action

GH action to check dependency licence issues using ort
https://github.com/marketplace/actions/tortellini-action
Apache License 2.0
3 stars 6 forks source link

Test workflow #125

Closed eriktks closed 3 years ago

eriktks commented 3 years ago

DRAFT

Description

Adding a test workflow. Approach:

  1. No test has been written for testing if the action succeeds or fails (seemed unnecessary)
  2. The existence of the report was tested with ls -l. If report is not there, the command fails and the action fails
  3. Pending discussion, the contents of the report has been compared against a fixed file. This will fail when the target repository (howfairis) is updated. However, a more flexible approach would require rebuilding tortellini for this test which feels like too much work. The comparison code with jq was taken from https://stackoverflow.com/questions/31930041/using-jq-or-alternative-command-line-tools-to-compare-json-files

Refs: #32


Before you get started

Checklist

This section should be filled in by the creator of this pull request to make sure the pull request is ready to review.

Instructions to review the pull request

Action should run and complete without errors

DRAFT

eriktks commented 3 years ago

Work on this task is continued in the branch PR #132