tortoise / tortoise-orm

Familiar asyncio ORM for python, built with relations in mind

https://tortoise.github.io

Apache License 2.0

4.38k stars 356 forks source link

fix: models get_or_create keyerror #1584

Closed jiangying000 closed 2 weeks ago

jiangying000 commented 2 months ago

1583

abondar commented 2 months ago

Could you please rebase your PR on actual develop branch? Also please add small test on it and info about change to changelog

jiangying000 commented 2 months ago

Could you please rebase your PR on actual develop branch? Also please add small test on it and info about change to changelog

yes, i did this

waketzheng commented 2 weeks ago

@jiangying000 How is that?

jiangying000 commented 2 weeks ago

@jiangying000 How is that?

sorry, no progress yet, too busy dealing with my employment job tasks

jiangying000 commented 2 weeks ago

feel free to take on this pr, or close it

waketzheng commented 2 weeks ago

feel free to take on this pr, or close it

I have make a pr, could you merge it into your develop branch? https://github.com/jiangying000/tortoise-orm/pull/1

jiangying000 commented 2 weeks ago

feel free to take on this pr, or close it

I have make a pr, could you merge it into your develop branch? jiangying000#1

done, thanks

waketzheng commented 2 weeks ago

@abondar Could you review this?

abondar commented 2 weeks ago

@waketzheng seems like there is some issue tests hangs up somewhere on ODBC tests

Also we would need to update changelog to put change in new section

waketzheng commented 2 weeks ago

@waketzheng seems like there is some issue tests hangs up somewhere on ODBC tests

Also we would need to update changelog to put change in new section

@abondar done

coveralls commented 2 weeks ago

Pull Request Test Coverage Report for Build 9501103456

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

13 of 16 (81.25%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.07%) to 89.021%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
tortoise/models.py	13	16	81.25%
<!--	Total:	13	16	81.25%	-->

Totals
Change from base Build 9479020180:	0.07%
Covered Lines:	5868
Relevant Lines:	6494

💛 - Coveralls

waketzheng commented 2 weeks ago

@abondar Cloud you review it?