tortoise / tortoise-orm

Familiar asyncio ORM for python, built with relations in mind

https://tortoise.github.io

Apache License 2.0

4.38k stars 356 forks source link

Fix models check method #1597

Closed vlakius closed 1 month ago

vlakius commented 2 months ago

Description

Renamed classmethod check to _check

Motivation and Context

1559 #1550

How Has This Been Tested?

I performed all the tests as well as manual tests

Checklist:

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have added the changelog accordingly.
[X] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[X] All new and existing tests passed.

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 8890195297

Details

2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.934%

Totals
Change from base Build 8879569614:	0.0%
Covered Lines:	5771
Relevant Lines:	6467

💛 - Coveralls

abondar commented 1 month ago

Hi

Please make more elaborate description on CHANGELOG, with breaking section, as we changed part of public api here

abondar commented 1 month ago

@vlakius are you planning to update this PR?

abondar commented 1 month ago

I replicated these changes with my own commit to include this changes in 0.21.0 https://github.com/tortoise/tortoise-orm/commit/a5be9b668268a5f48979f1b4fa348c1198c88720