More efficient `utils.chunk`

Abdeldjalil-H commented 1 month ago

The utils.chunk function from tortoise.utils is converting instances into list. I think it is better to not load all the list at one time but rather in chunks as the name suggested. This is useful in cases when the user passes a generator instead of list especially for large datasets.

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have added the changelog accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9058250244

Details

10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 87.943%

Totals
Change from base Build 9028420328:	0.01%
Covered Lines:	5776
Relevant Lines:	6472

💛 - Coveralls

Abdeldjalil-H commented 1 month ago

It seems that the failing tests have nothing to do with the changes made, because the changed part is not being called at all for the failed test case. Moreover, it passes the first time, then when I changed contrubitors file it fails!

tortoise / tortoise-orm