refactor: share logic for signal listeners - Githubissues

tortoise / tortoise-orm

Familiar asyncio ORM for python, built with relations in mind

https://tortoise.github.io

Apache License 2.0

4.57k stars 377 forks source link

refactor: share logic for signal listeners #1630

Closed waketzheng closed 4 months ago

waketzheng commented 4 months ago

Description

Use list comprehension to replace some for-append format
Import StrEnum from standard library with py3.11+
Define property_kwargs for _fk_getter/setter
Share logic for signals listening: pre_save/post_save/pre_delete/post/delete
fix new version ruff warning

Motivation and Context

refactor

How Has This Been Tested?

make ci

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added the changelog accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9236872221

Details

16 of 16 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 87.853%

Totals
Change from base Build 9236326640:	-0.03%
Covered Lines:	5759
Relevant Lines:	6458

💛 - Coveralls