Fix breaking change of `DoesNotExist` - Githubissues

tortoise / tortoise-orm

Familiar asyncio ORM for python, built with relations in mind

https://tortoise.github.io

Apache License 2.0

4.37k stars 355 forks source link

Fix breaking change of `DoesNotExist` #1650

Closed waketzheng closed 2 weeks ago

waketzheng commented 2 weeks ago

Description

It is better to avoid breaking changes

Motivation and Context

Let's support both old style of DoesNotExist('This is a string') and new style of DoesNotExist(ModelClass)

How Has This Been Tested?

make ci

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added the changelog accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

coveralls commented 2 weeks ago

Pull Request Test Coverage Report for Build 9503111770

Details

17 of 17 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 88.98%

Totals
Change from base Build 9479020180:	0.03%
Covered Lines:	5865
Relevant Lines:	6491

💛 - Coveralls