tortoise / tortoise-orm

Familiar asyncio ORM for python, built with relations in mind
https://tortoise.github.io
Apache License 2.0
4.37k stars 355 forks source link

refactor: use db queryset to reduce duplicated code #1652

Closed waketzheng closed 1 week ago

waketzheng commented 2 weeks ago

Description

There are server repeat code segments in tortoise/models.py as follows:

db = using_db or cls._choose_db()
cls._meta.manager.get_queryset().using_db(db)

Motivation and Context

Add a new classmethod _db_queryset to Model

How Has This Been Tested?

make ci

Checklist:

coveralls commented 2 weeks ago

Pull Request Test Coverage Report for Build 9513948759

Details


Totals Coverage Status
Change from base Build 9479020180: -0.003%
Covered Lines: 5853
Relevant Lines: 6481

💛 - Coveralls
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9537193587

Details


Totals Coverage Status
Change from base Build 9534241702: -0.004%
Covered Lines: 5868
Relevant Lines: 6492

💛 - Coveralls
coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9537259684

Details


Totals Coverage Status
Change from base Build 9534241702: -0.004%
Covered Lines: 5868
Relevant Lines: 6492

💛 - Coveralls