Improve type hints for backends - Githubissues

tortoise / tortoise-orm

Familiar asyncio ORM for python, built with relations in mind

https://tortoise.github.io

Apache License 2.0

4.37k stars 355 forks source link

Improve type hints for backends #1660

Open waketzheng opened 1 week ago

waketzheng commented 1 week ago

Description

Improve type hints to reduce type:ignore

Motivation and Context

Only make style and improve type hint without changing any code logic

How Has This Been Tested?

make test

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added the changelog accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9559961752

Details

38 of 45 (84.44%) changed or added relevant lines in 8 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 89.023%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
tortoise/backends/oracle/client.py	1	2	50.0%
tortoise/contrib/mysql/fields.py	0	1	0.0%
tortoise/backends/oracle/executor.py	2	7	28.57%
<!--	Total:	38	45	84.44%	-->

Totals
Change from base Build 9543663341:	-0.03%
Covered Lines:	5870
Relevant Lines:	6496

💛 - Coveralls

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9562810843

Details

38 of 45 (84.44%) changed or added relevant lines in 8 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 89.023%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
tortoise/backends/oracle/client.py	1	2	50.0%
tortoise/contrib/mysql/fields.py	0	1	0.0%
tortoise/backends/oracle/executor.py	2	7	28.57%
<!--	Total:	38	45	84.44%	-->

Totals
Change from base Build 9543663341:	-0.03%
Covered Lines:	5870
Relevant Lines:	6496

💛 - Coveralls

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9565173623

Details

38 of 45 (84.44%) changed or added relevant lines in 8 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 89.023%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
tortoise/backends/oracle/client.py	1	2	50.0%
tortoise/contrib/mysql/fields.py	0	1	0.0%
tortoise/backends/oracle/executor.py	2	7	28.57%
<!--	Total:	38	45	84.44%	-->

Totals
Change from base Build 9563237685:	-0.03%
Covered Lines:	5870
Relevant Lines:	6496

💛 - Coveralls

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 9565355799

Details

38 of 45 (84.44%) changed or added relevant lines in 8 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 89.024%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
tortoise/backends/oracle/client.py	1	2	50.0%
tortoise/contrib/mysql/fields.py	0	1	0.0%
tortoise/backends/oracle/executor.py	2	7	28.57%
<!--	Total:	38	45	84.44%	-->

Totals
Change from base Build 9563237685:	-0.03%
Covered Lines:	5870
Relevant Lines:	6496

💛 - Coveralls