tortoise / tortoise-orm

Familiar asyncio ORM for python, built with relations in mind
https://tortoise.github.io
Apache License 2.0
4.39k stars 357 forks source link

Fix one of the models TODOs #1669

Open waketzheng opened 5 days ago

waketzheng commented 5 days ago

Description

Motivation and Context

fix TODO and improve type hint

How Has This Been Tested?

make ci

Checklist:

coveralls commented 5 days ago

Pull Request Test Coverage Report for Build 9714895282

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
tortoise/models.py 14 22 63.64%
<!-- Total: 28 36 77.78% -->
Totals Coverage Status
Change from base Build 9646263030: -0.2%
Covered Lines: 5913
Relevant Lines: 6546

💛 - Coveralls
coveralls commented 3 days ago

Pull Request Test Coverage Report for Build 9731350025

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
tortoise/models.py 14 22 63.64%
<!-- Total: 28 36 77.78% -->
Totals Coverage Status
Change from base Build 9646263030: -0.2%
Covered Lines: 5913
Relevant Lines: 6546

💛 - Coveralls
Creat-qc commented 1 day ago

@waketzheng 老哥, 能描述一下问题出现原因和修复的逻辑吗🎨。因为其他项目没有出现,现在复现场景我们也不明确。