Parametrize UPDATE, DELETE and bulk operations - Githubissues

tortoise / tortoise-orm

Familiar asyncio ORM for python, built with relations in mind

https://tortoise.github.io

Apache License 2.0

4.69k stars 390 forks source link

Parametrize UPDATE, DELETE and bulk operations #1785

Open henadzit opened 1 day ago

henadzit commented 1 day ago

Description

It's a follow up to https://github.com/tortoise/tortoise-orm/pull/1777.

Parametrizes UPDATE, DELETE and bulk update and create operations

From my knowledge this should be the last bit of parametrization work.

⚠️ we should not merge it until https://github.com/tortoise/pypika-tortoise/pull/17 is merged and a new version is released.

Motivation and Context

Parameterized queries are crucial for preventing SQL injection attacks and but also can improve performance of database operations.

Related ticket https://github.com/tortoise/tortoise-orm/issues/81 v1.0.0 target https://github.com/tortoise/tortoise-orm/issues/19

How Has This Been Tested?

Tests
Tested with a web app localy

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added the changelog accordingly.
[ ] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

coveralls commented 1 day ago

Pull Request Test Coverage Report for Build 11996286319

Details

34 of 35 (97.14%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 89.618%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
tortoise/queryset.py	28	29	96.55%
<!--	Total:	34	35	97.14%	-->

Totals
Change from base Build 11994314143:	0.1%
Covered Lines:	6239
Relevant Lines:	6854

💛 - Coveralls