search

torusresearch / customauth-swift-sdk

Swift SDK that allows applications to directly interact with the Torus Network, similar to how Torus Wallet does.
BSD 3-Clause "New" or "Revised" License
10 stars 17 forks source link

Crash on login using Google #47

Closed vantam87 closed 1 year ago

vantam87 commented 1 year ago

Hi @michaellee8 ,

Thank you for your help on the issue again.

Could you please check the function getVerifierFromUserInfo? We still get crashes from GoogleloginHandler in the latest version 4.1.0. Is it possible to omit force unwrap it also?

func getVerifierFromUserInfo() -> String {
        return self.userInfo!["email"] as! String
}

Thank you in advance

michaellee8 commented 1 year ago

@vantam87 I no longer work for Web3Auth, @dhruvTor can you take over this? I think it should be ok to make it return empty string if the field is not populated and then cause it to fail gracefully.

dhruvTor commented 1 year ago

Yes let me have a look into this

dhruvTor commented 1 year ago

Hey @vantam87 the new version of CustomAuth swift sdk (4.1.1) has been released with the fix, If you are using cocoapods please try after an hour or so cause it's CI takes some time, Do let me know if you face any issue.

vantam87 commented 1 year ago

@dhruvTor thank you very much for the quick fix. 🙏

vantam87 commented 1 year ago

This was fixed in PR