search

torusresearch / customauth-swift-sdk

Swift SDK that allows applications to directly interact with the Torus Network, similar to how Torus Wallet does.
BSD 3-Clause "New" or "Revised" License
10 stars 17 forks source link

MacOS #56

Closed simonmcl closed 1 year ago

simonmcl commented 1 year ago

you added macos support 10.15 to all the other swift packages (torus utils, fetch node details etc). But left this one blank. When you leave it blank, it defaults to 10.13 under the hood. This conflicts with the other packages set to 10.15, causing it to throw an error. This doesn't just affect MacOS support, but also causes issues inside Xcode 14.3 for iOS now that they've dropped rosetta as the default option.

Can you either try drop torus utils + fnd to 10.13 or add 10.15 to this one please

simonmcl commented 1 year ago

cc: @chaitanyapotti

chaitanyapotti commented 1 year ago

Released 6.0.1

simonmcl commented 1 year ago

@chaitanyapotti ... doesn't compile

Screenshot 2023-07-17 at 15 25 22

chaitanyapotti commented 1 year ago

It actually doesn't compile for macOS. That's why it didn't include it before. I added the macOS setting to fix your issue. You shouldn't actually compile it for macOS.

chaitanyapotti commented 1 year ago

Alternatively, I can drop macOS support everywhere. This and other torus packages are intended for iOS only.

simonmcl commented 1 year ago

@chaitanyapotti I requested MacOS in the past, because we have plans to build desktop app eventually. I wasn't requesting that a setting be turned on for no reason. Is MacOS support something you can add to your roadmap? I would assume the only thing that needs to change is how the browser is opened, which shouldn't be a huge lift

simonmcl commented 11 months ago

@chaitanyapotti hi this is still causing me issues with tooling. If macos is not supported, can you please remove it?