search

torusresearch / solana-embed

Embeds the Solana Wallet directly in your application via solana-embed. Exposes a Web3 Provider.
https://demo-solana.tor.us
12 stars 6 forks source link

"is-stream" is an ESM package and cannot be used in the .cjs bundle #31

Closed monsonjeremy closed 2 years ago

monsonjeremy commented 2 years ago

is-stream version 3.0.0 is an ESM only package, therefore when used in the CJS bundle untranspiled it causes errors in webpack/next-js/etc... This library should likely use ^2.0.0 or ship only a .esm bundle.

metallicalfa2 commented 2 years ago

@ieow

ieow commented 2 years ago

@monsonjeremy is right. downgrade is-stream to ^2.0.0

pgarciaegido commented 2 years ago

Hey guys,

When are you guys releasing the fix for this? Any way we can overcome this without a release from you guys?

Thanks a lot!!!

ieow commented 2 years ago

I think the better way to load embed is using dynamic loading.

check this PR https://github.com/solana-labs/dapp-scaffold/pull/154

ieow commented 2 years ago

32 is merged