search

torusresearch / torus-embed

Embeds the Torus Wallet directly in your application via torus-embed. Exposes a Web3 Provider.
https://demo-eth.tor.us
MIT License
85 stars 52 forks source link

Missing value for field error after signing message #310

Closed bitbeckers closed 3 years ago

bitbeckers commented 3 years ago

Describe the bug When signing a message with the Torus embed module to relay a metatx via Biconomy, the transaction flow errors out. When using DAI approve this does not happen, so it should be able to process the signature instead of reporting it as undefined.

To Reproduce https://github.com/bitbeckers/torus-biconomy-metatx

The main branch has a hardcoded flow to showcase the error.

  1. yarn start
  2. Monitor console for "READY"
  3. Click big blue button
  4. Check the console.log for the error

Expected behavior No missing values reported

Screenshots screenshot

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

Edit: typo

bitbeckers commented 3 years ago

Discrapancy between domainData and domainType value. Will refactor and test. No action needed for now.

bitbeckers commented 3 years ago

Closing issue since it was indeed the mismatch between domain data and domain type