secp256k1: Use lib functions instead of custom implementations?

torusresearch / torus-utils-swift

Swift package for fetching shares from torus-nodes

BSD 3-Clause "New" or "Revised" License

4 stars 11 forks source link

secp256k1: Use lib functions instead of custom implementations? #63

Closed matthiasgeihs closed 8 months ago

matthiasgeihs commented 9 months ago

In SECP256k1.swift we have implementations of ecdh and signing with pubkey recovery. On the other hand, the secp256k1 library that we use seems to have these functions baked in (see README).

Suggestion

Replace custom implementations of ecdh and signing with pubkey recovery in torus-utils-swift with function calls to the corresponding methods of the secp256k1.swift library.

metalurgical commented 8 months ago

Just to add more context to this issue. There is actually a discrepancy here between SPM and cocoapods. The secp256k1 for gigabitcoin is not available on cocoapods, the boilertalk secp256k1 is used instead.

matthiasgeihs commented 8 months ago

The original issue I pointed out here is resolved in #66.

@metalurgical Anything else that is left open in your opinion? If so, please reopen or create a different issue.