search

torusresearch / torus-utils-swift

Swift package for fetching shares from torus-nodes
BSD 3-Clause "New" or "Revised" License
5 stars 11 forks source link

feat: full refactor to align torus-utils-swift to torus.js #97

Closed metalurgical closed 2 months ago

metalurgical commented 4 months ago

This PR seeks to re-align the current implementation of torus-utils-swift to that of the web implementation of torus.js.

This will reduce the overhead of differences a developer would need to remember between the two and provide an overall better experience.

This will also provide better long term maintainability and make feature parity simpler to implement between the two.

The are also numerous bug fixes implemented in this PR as well, one of which allowed the package AnyCodable as a dependency to be removed.

This PR should be feature-complete up until tag v12.3.5 on torus.js (commit hash: 0160ae8fb4c622ba44c1e80872da2d17cb0e8650). Note: The import share implementation is a simplified implementation taken from the alpha branch of the same repo.

Note this is a breaking change and needs to be released as a major version.

For reviewers, it will be significantly easier to review this side-by-side with web rather than just trying to review the diff. Probably the best way to start would be to compare the test cases first.

metalurgical commented 4 months ago

Closes #94

metalurgical commented 4 months ago

Resolve #95 Resolve #96 Close #95 Close #96