torusresearch / torus-website

Torus Wallet that provides dapps logins that feel like Web2.0
https://app.tor.us
Other
78 stars 50 forks source link

An in-range update of web3 is breaking the build 🚨 #1114

Closed greenkeeper[bot] closed 4 years ago

greenkeeper[bot] commented 4 years ago

🚨 Reminder! Less than one month left to migrate your repositories over to Snyk before Greenkeeper says goodbye on June 3rd! πŸ’œ πŸššπŸ’¨ πŸ’š

Find out how to migrate to Snyk at greenkeeper.io


The dependency web3 was updated from 1.2.7 to 1.2.8.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

web3 is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details - ❌ **ci/circleci: test-coverage:** Your tests failed on CircleCI ([Details](https://circleci.com/gh/torusresearch/torus-website/7734?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)).

Release Notes for web3.js 1.2.8

Hi!

Features

Alongside some Typescript improvements and patches for the Websocket Provider reconnection logic introduced in 1.2.7, this release contains two larger changes:

  • Ethers ABI Coder has received a full version increment, from 4.0.0-beta.3 to 5.0.0-beta.153. Since 2018, Web3 has relied on @ricmoo's great Ethers project to manage encoding and decoding data passed between Web3 and the EVM. This update should allow Web3 to absorb the latest work at Ethers going forward.

    The new ABI coder runs additional checks to validate inputs against the ABI types. Behavioral differences include:

Edge case Web3 <= 1.2.7 Web3 1.2.8
Input exceeds an ABI type's max value (ex: "257" for uint8) overflows out of bounds error
Negative input for uint underflows out of bounds error
Invalid utf-8 character in string silently sanitized utf-8 error
  • The ENS module now supports ENS's contenthash feature (EIP 1577), which allows you to associate an IPFS or Swarm hash with an ENS domain. There's a nice introduction to content hashes in this ENS medium post. Docs for the newly added methods can be found here.

Added

  • Introduce review and release guidelines. (#3460)
  • Add EIP-1193 compatible provider to AbstractProvider interface. (#3499, #3521)
  • Add Typescript definitions for contract call. (#3454, #3521)
  • Add support for ENS contenthash methods (#3392, #2782, #3511)

Changed

  • Change CI provider from Travis to Github Actions. (#3468)
  • Update web3-eth-abi ABICoder dependency. (#3490, #3522)
  • Improve code clarity of HttpProvider keepAlive option setting. (#3463)
  • Updated type definitions for Web3 HTTP Provider. (#3482)
  • Improve code clarity of HttpProvider keepAlive value. (#3463)
  • Fix indentation of web3-eth documentation (#3478)

Fixed

  • Fix intermittent CI build issues with dtslint. (#3479)
  • Fix WSS credentials Base64 encoding (for browser) (#3508)
  • Fire provider "error" and/or "end" events when Websocket provider disconnects (#3485)
  • Remove web3-eth revert error return types to squash TS compilation errors (#3496)
  • Backfill event subscriptions when WS connection dropped across multiple blocks (#3491)
  • Stop swallowing errors when WS connection has died after exhausting reconnection attempts (#3492)
Commits

The new version differs by 143 commits ahead by 143, behind by 7.

  • e5b3b37 v1.2.8
  • 6289002 v1.2.8-rc.1
  • fcf5d22 Add 1.2.8-rc.1 changelog entries
  • ba7677d Merge pull request #3522 from ethereum/abiCoderParamFormatting
  • 16c44d4 Fix setContenthash docs formatting (#3511)
  • d13c468 Add detail to compatibility comment
  • b7dbcd6 handle more encoding rules to reduce any breaking changes for abicoder dep update
  • 58d1f5b Merge pull request #3521 from ethereum/fix/release-tsc-errors
  • 7911e5d Apply geth 1.9.13 CI fix to release branch
  • 7d27f50 Revert contract.method TS definition change (PR #3454)
  • 14a0272 Add optional connected property to AbstractProvider type
  • 035d11a v1.2.8-rc.0
  • dd4c8ec Merge pull request #3507 from ethereum/changelog-1.2.8.rc.0
  • e94013f Add headers
  • 26db9c1 Create 1.2.9 entry

There are 143 commits in total.

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

chaitanyapotti commented 4 years ago

resolved