search

toryas / serverless-glue

This is a plugin for Serverless framework that provide the possibility to deploy AWS Glue Jobs and Triggers
25 stars 30 forks source link

createBucket not listed in "How configure your GlueJobs" sectioon #20

Closed bdb2381 closed 2 years ago

bdb2381 commented 2 years ago

The section Glue: bucketDeploy: someBucket # Required s3Prefix: some/s3/key/location/ # optional, default = 'glueJobs/' tempDirBucket: someBucket # optional, default = '{serverless.serviceName}-{provider.stage}-gluejobstemp' tempDirS3Prefix: some/s3/key/location/ # optional, default = ''. The job name

does not mention createBucket: string, which caused a little bit of challenge deploying with a new bucket.

If wanted, I can update the readme for more specifics with both the above createBucket and additional clarification where I ran into issues.

toryas commented 2 years ago

I can´t found any error without more information.

bdb2381 commented 2 years ago

@toryas The missing information is in the ReadMe.me, under the example Glue: section:

It should be this (notice the creatBucket addition)

Glue:
       bucketDeploy: someBucket # Required
      **createBucket: true**
      s3Prefix: some/s3/key/location/ # optional, default = 'glueJobs/'
     tempDirBucket: someBucket # optional, default = '{serverless.serviceName}-{provider.stage}-gluejobstemp'
      tempDirS3Prefix: some/s3/key/location/ # optional, default = ''. The job name will be appended to the prefix name

  jobs:
toryas commented 2 years ago

thanks @bdb2381 I improve the documentation