search

tosdr / browser-extensions

Browser extensions for Terms of Service; Didn't Read. “I have read and agree to the Terms” is the biggest lie on the web. We aim to fix that. Get informed instantly about websites' terms & privacy policies, with ratings and summaries from the www.tosdr.org initiative.
http://tosdr.org/downloads
GNU Affero General Public License v3.0
393 stars 44 forks source link

extension has no function #14

Closed davidak closed 3 years ago

davidak commented 6 years ago

I installed the extension, but it has no function.

screenshot from 2018-07-15 21-09-10

This is how it looks when i have https://github.com/tosdr/browser-extensions/issues/13 open. That issue might also be the reason.

Chromium 65.0.3325.162

shybyte commented 6 years ago

@michielbdejong @piks3l It seems that the format of the API response (like in https://tosdr.org/services/youtube.json) has changed. For example, there is no url attribute anymore but an urls attribute. Is this an intended change? Is there another API endpoint that is compatible with the old format? Is the new format documented and stable?

shybyte commented 6 years ago

@michielbdejong @piks3l @tosdr/phoenix @tosdr/browser-extensions-developers These API changes break probably not only the chrome extension, but others too, like for example https://github.com/tosdr/tosdr-firefox/issues/51.

michielbdejong commented 6 years ago

Looking at https://github.com/tosdr/tosdr.org/wiki/Specification:-services/_history it seems this API change had already happened before May 2013, and also it makes no sense to have a single .url field, many services have multiple domain names, so .urls is better. I think we should fix it in all browser extensions, like @floSoX already did in #17.